feat(dom): DOM - toHaveFocus #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suany0805
reviewed
Jul 10, 2025
| const error = new AssertionError({ | ||
| actual: this.actual, | ||
| expected: document.activeElement, | ||
| message: "Expected the element to have focus.", |
There was a problem hiding this comment.
What do you think about the messaging to be:
"Expected the element to be focused" ?
suany0805
reviewed
Jul 10, 2025
| const invertedError = new AssertionError({ | ||
| actual: this.actual, | ||
| expected: document.activeElement, | ||
| message: "Expected the element not to have focus.", |
There was a problem hiding this comment.
also in here, what do you think about the messaging to be:
"Expected the element NOT to be focused" ?
lopenchi
reviewed
Jul 14, 2025
Comment on lines
+288
to
+291
| const input1 = getByTestId("input1"); | ||
| const input2 = getByTestId("input2"); | ||
| input1.focus(); | ||
| const test = new ElementAssertion(input2); |
There was a problem hiding this comment.
Just a suggestion.
If you dont add .focus() , any element is focused so, I think the test could be easier like
Suggested change
| const input1 = getByTestId("input1"); | |
| const input2 = getByTestId("input2"); | |
| input1.focus(); | |
| const test = new ElementAssertion(input2); | |
| const input1 = getByTestId("input1"); | |
| const test = new ElementAssertion(input1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the toHaveFocus matcher with its tests.